handle smaller sync responses introduced in synapse 1.38.0#321
Merged
Conversation
anoadragon453
requested changes
Jul 21, 2021
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
This looks functional, just a couple stylistic notes.
Also note that this library is no longer actively maintained. You may consider switching to another Python library for client actions, such as https://github.com/poljar/matrix-nio.
Contributor
Author
I know :) I only wanted to keep the home assistant matrix integration functional. They should switch to matrix-nio anyway. |
anoadragon453
approved these changes
Jul 22, 2021
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Thanks for making those changes, and yes that's understandable!
This was referenced Jul 23, 2021
axkg
added a commit
to axkg/teslausb
that referenced
this pull request
Jul 26, 2021
Latest synpase update broke the legacy SDK: matrix-org/matrix-python-sdk#321 Even though the fix is merged, PyPI package is unlikey to update soon as SDK is no longer maintained, so it is now replaced with matrix-nio.
marcone
pushed a commit
to marcone/teslausb
that referenced
this pull request
Jul 30, 2021
Latest synapse update broke the legacy SDK: matrix-org/matrix-python-sdk#321 Even though the fix is merged, PyPI package is unlikey to update soon as SDK is no longer maintained, so it is now replaced with matrix-nio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synapse 1.38.0 introduced smaller sync responses (matrix-org/synapse#10214) by removing empty fields, but this library did not handle it correctly.
This broke the Home Assistant matrix integration, for example.