This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Percy: hide timestamp in permalink rendering screenshot test#10836
Merged
kerryarchibald merged 7 commits intoMay 12, 2023
Conversation
kerryarchibald
added
the
T-Task
kerryarchibald
added
the
X-Needs-Percy
t3chguy
approved these changes
May 10, 2023
luixxiul
reviewed
May 10, 2023
| cy.get(".mx_GenericEventListSummary").invoke("remove"); | ||
|
|
||
| cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering"); | ||
| const percyCSS = ".mx_MessageTimestamp, .mx_RoomView_myReadMarker { visibility: hidden !important; }"; |
Contributor
There was a problem hiding this comment.
This will have to be updated once #10745 is merged.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
3 tasks
Member
|
The status checks were Percy checks that I have ticked, and the "no artifacts found" flake from our SonarCloud job. Re-running. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Member
|
no artifacts found - should work after #10863 is merged |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
kerryarchibald
removed
the
X-Needs-Percy
Contributor
Author
|
Percy check seems to return failure as soon as the screenshots are ready in percy, so even if you babysit the PR and approve the percy build as soon as it is ready the PR is already kicked from the build queue. |
This was referenced May 12, 2023
Member
Yeah I've noticed the same behaviour :-( |
richvdh
pushed a commit
that referenced
this pull request
May 12, 2023
* hide timestamp * retrigger sonar * trigger build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://percy.io/dfde73bd/matrix-react-sdk/builds/27244298/changed/1515623098?browser=chrome&browser_ids=36%2C38%2C39&subcategories=unreviewed%2Cchanges_requested&viewLayout=overlay&viewMode=new&width=1920&widths=264%2C1024%2C1920
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.