This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Update Percy snapshots for the font scaling slider#10858
Closed
luixxiul wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
Z-Community-PR
kerryarchibald
added
the
X-Needs-Percy
kerryarchibald
approved these changes
May 12, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
The snapshots were taken as expected: https://percy.io/dfde73bd/matrix-react-sdk/builds/27331687/search?searchParam=font%20scaling%20panel |
Contributor
Author
|
The PR failed on the merge queue in the same way as #10836 (comment) |
Contributor
Author
|
It seems it has been fixed upstream: https://percy.io/dfde73bd/matrix-react-sdk/builds/27613187/search?searchParam=font%20size%20slider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#25333
This PR intends to update Percy snapshots for the font scaling slider in order to have Percy take the font scaling panel, instead of the slider since it seems that Percy does not take the
align-itemsandbackgroundvalues into consideration.type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.