This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Disable flaky Percy tests#10878
Merged
Merged
Conversation
andybalaam
force-pushed
the
andybalaam/disable-flaky-permalink
branch
from
152c0d1 to
e0101f3
Compare
richvdh
approved these changes
May 12, 2023
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
As I've already said elsewhere, I'm not a big fan of this approach because my experience is that, once a test is disabled, it will never be re-enabled.
But if this is the only practical solution for now, so be it
andybalaam
added
the
T-Task
Member
Author
|
I agree with your distate and I agree that it's the only practical thing to do right now. Anyone reading along who wants to fix any of the currently-open Flaky tests, I will personally thank you profusely and/or buy you a real pint if you fix one. |
This was referenced May 12, 2023
richvdh
pushed a commit
that referenced
this pull request
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See element-hq/element-web#25283 and element-hq/element-web#24881
This change is marked as an internal change (Task), so will not be included in the changelog.