Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Disable flaky Percy tests #10878

Merged
andybalaam merged 1 commit into from
May 12, 2023
Merged

Disable flaky Percy tests #10878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cypress/e2e/permalinks/permalinks.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ describe("permalinks", () => {
cy.get(".mx_NewRoomIntro").invoke("remove");
cy.get(".mx_GenericEventListSummary").invoke("remove");

const percyCSS = ".mx_MessageTimestamp, .mx_RoomView_myReadMarker { visibility: hidden !important; }";
cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering", { percyCSS });
// Disabled because flaky - see https://github.com/vector-im/element-web/issues/25283
//const percyCSS = ".mx_MessageTimestamp, .mx_RoomView_myReadMarker { visibility: hidden !important; }";
//cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering", { percyCSS });
});
});
9 changes: 5 additions & 4 deletions cypress/e2e/timeline/timeline.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ describe("Timeline", () => {
cy.get(".mx_RoomView_body .mx_EventTile_info .mx_MessageTimestamp").click();

// Exclude timestamp and read marker from snapshot
const percyCSS = ".mx_MessageTimestamp, .mx_RoomView_myReadMarker { visibility: hidden !important; }";
//const percyCSS = ".mx_MessageTimestamp, .mx_RoomView_myReadMarker { visibility: hidden !important; }";

// should not add inline start padding to a hidden event line on IRC layout
cy.setSettingValue("layout", null, SettingLevel.DEVICE, Layout.IRC);
Expand All @@ -604,9 +604,10 @@ describe("Timeline", () => {
// calc(var(--EventTile_group_line-spacing-inline-start) + 20px) = 64 + 20 = 84px
.should("have.css", "padding-inline-start", "84px");

cy.get(".mx_MainSplit").percySnapshotElement("Hidden event line with padding on modern layout", {
percyCSS,
});
// Disabled because flaky - see https://github.com/vector-im/element-web/issues/24881
//cy.get(".mx_MainSplit").percySnapshotElement("Hidden event line with padding on modern layout", {
// percyCSS,
//});
});

it("should click view source event toggle", () => {
Expand Down