Use BaseDialog for DeactivateAccountDialog

[aidalgol]

Alter DeactivateAccountDialog to derive from BaseDialog.

Fixes element-hq/element-web#5694.

Signed-off-by: Aidan Gauland aidalgol@fastmail.net

[pafcu]

Isn't DeactivateAccountDialog basically a QuestionDialog with the addition of a password check? Would it be possible to either base this off QuestionDialog, or turn this into some sort of more generic QuestionWithPasswordConfirmationDialog (at some point in the future if not now?)

[dbkr]

Looks like this will lose the red title from the dialog, This isn't necessarily a problem if everyone if OK with that?

[pafcu]

Getting out of scope for this PR, but might make sense to have some sort of generic importance flag (which would control if you get a "normal" dialog, or red titles, big exclamation marks etc.)

[lukebarnard1]

IMO, it'd be a simple enough change to have an optional property as @pafcu suggests that applies the danger CSS class in BaseDialog. However, this will conflict with #1652, so let's get that merged first, I think.

[dbkr]

Regrettably blocked behind #1652

[dbkr]

Closing since this is now superseded by your other PR (#1674)

[aidalgol]

Oops, sorry for the doubleup!