This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Normalise dialogs#1674
Merged
Merged
Conversation
Some dialogs need to set additional classes on the `mx_Dialog_title` `div` element (for example `danger`).
A component to normalise the buttons in dialogs.
Use DialogButtons to eliminate duplicate button code.
Use DialogButtons to eliminate duplicate button code.
Use DialogButtons to eliminate duplicate button code.
We can't use DialogButtons because the primary button is an <input> element.
Use DialogButtons to eliminate duplicate button code.
Use DialogButtons to eliminate duplicate button code.
Use DialogButtons to eliminate duplicate button code.
Use DialogButtons to eliminate duplicate button code.
Use DialogButtons to eliminate duplicate button code.
t3chguy
suggested changes
Dec 25, 2017
|
|
||
| propTypes: { | ||
| // The primary button which is styled differently and has default focus. | ||
| primaryButton: React.PropTypes.node.isRequired, |
Member
There was a problem hiding this comment.
please use PropTypes and import PropTypes from 'prop-types'; as React.PropTypes is going away
Use PropTypes from "prop-types" instead of the deprecated React.PropTypes submodule.
dbkr
suggested changes
Jan 5, 2018
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
Couple of minor things, but otherwise this looks good, thanks!
| limitations under the License. | ||
| */ | ||
|
|
||
| "use strict"; |
Author
There was a problem hiding this comment.
Is that referring to the "use scrict"? The lines you've highlighted make this a bit unclear.
Member
There was a problem hiding this comment.
Yes, sorry - use strict isn't necessary in a module (they're all implicitly strict).
| @@ -0,0 +1,62 @@ | |||
| /* | |||
| Copyright 2015, 2016 OpenMarket Ltd | |||
Member
There was a problem hiding this comment.
You wrote this file, so you should claim the copyright
dbkr
approved these changes
Jan 11, 2018
dbkr
added a commit
that referenced
this pull request
Jan 12, 2018
'focus' attribute was on the wrong thing
dbkr
added a commit
that referenced
this pull request
Feb 6, 2018
Another regression from #1674 Fixes element-hq/element-web#5994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseDialog.DialogButtonscomponent to be used in most dialog components for the purpose of normalising the order of dialog buttons.Addresses element-hq/element-web#5689
Signed-off-by: Aidan Gauland aidalgol@fastmail.net