Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Change the look of the default spinner#4491

Closed
anoadragon453 wants to merge 1 commit into
developfrom
anoa/new_spinner_look
Closed

Change the look of the default spinner#4491
anoadragon453 wants to merge 1 commit into
developfrom
anoa/new_spinner_look

Conversation

@anoadragon453
Copy link
Copy Markdown
Member

@anoadragon453 anoadragon453 commented Apr 24, 2020

Video demonstration: https://matrix.amorgan.xyz/_matrix/media/r0/download/amorgan.xyz/5c5000dad6e0a144835ff1d56b69695d764c05c3

Replaces the old spinner as it:

  • Didn't adapt to dark themes
  • Didn't look great

This PR adds a new style of spinner, done in SVG, and consolidates all the different uses of spinners into two react classes.

@t3chguy
Copy link
Copy Markdown
Member

t3chguy commented Apr 24, 2020

Conflicts with #4002 which was blocked on Matthew's CSS animation performance woes. (he thinks it'll be the rebirth of element-hq/element-web#329)

@anoadragon453
Copy link
Copy Markdown
Member Author

ha ha

sad times

@anoadragon453
Copy link
Copy Markdown
Member Author

Superseded by #4842

@anoadragon453 anoadragon453 deleted the anoa/new_spinner_look branch June 26, 2020 00:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants