This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add a new spinner design behind a labs flag#4842
Merged
Merged
Conversation
t3chguy
reviewed
Jun 26, 2020
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
Looks sane, but doesn't it need a filter invert somewhere for dark mode?
Member
Author
Check the video. I switched the spinner's colour to green which works on light and dark backgrounds 🙂 |
Member
|
Oh dear, completely missed there was a video :D |
t3chguy
approved these changes
Jun 26, 2020
Member
|
Test fail due to outdated base branch |
… anoa/new_spinner * 'develop' of github.com:matrix-org/matrix-react-sdk: bandaid make js-sdk import happy? ts-ignore because something is made of fail js-sdk imports suck Iterate on the new room list resize handle Welcome no longer needs any props unexport things which need not exporting Instead of passing sso and cas urls to Welcome, route via start_sso and start_cas Move to mx_sso_hs_url and co for sso persistance to not conflict with guest creds Fix Welcome.html URLs improve typing Add account and room-account data hooks Create a StaticNotificationState for representative purposes Add StyledRadioGroup to simplify use of StyledRadioButton and use in Appearance Tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video of the new design in action: https://matrix.amorgan.xyz/_matrix/media/r0/download/amorgan.xyz/71953f90530066a42768acd2280bff92851a40d4
Placed behind the labs flag
feature_new_spinner.