This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Improve switch room rendering#6079
Merged
Merged
Conversation
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
Only render MessageTimestamp to the DOM when a tile is hovered
turt2live
reviewed
May 21, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
overall looks fine - just a few relatively minor concerns. Thanks for poking this!
turt2live
reviewed
May 26, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
github wants words in this box
Member
|
also merge conflicts (already) :( |
turt2live
approved these changes
Jun 3, 2021
11 tasks
jryans
added a commit
that referenced
this pull request
Jun 4, 2021
#6079 caused a regression in the event status indicator. The `mx_EventTile_msgOption` container was folded into the avatars code path, but the event status is a special case of this, so it now needs to also have this container to preserve its positioning. Fixes element-hq/element-web#17552
Merged
This was referenced Jun 6, 2021
This was referenced Jun 7, 2021
jryans
added a commit
that referenced
this pull request
Jun 16, 2021
A recent change (47e007e) introduced a regression where we failed to check whether a reply thread has a next reply. This meant that we would end up sending `/context/undefined` requests to the server for every reply thread on every room view. Fixes element-hq/element-web#17563 Regressed by #6079
jryans
added a commit
that referenced
this pull request
Jun 17, 2021
A recent change (47e007e) introduced a regression where we failed to check whether a reply thread has a next reply. This meant that we would end up sending `/context/undefined` requests to the server for every reply thread on every room view. Fixes element-hq/element-web#17563 Regressed by #6079
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves element-hq/element-web#4997
This reduces the time it takes to switch rooms without undergoing massive changes in
TimelinePanelorScrollPanel. There are a lot of room for improvement there but the changes required are a lot more invasiveTwo main optimisations are applied here
setStatecalls together and leveraging cached values to avoid a two step render where possibleWhen using a development build of react I managed to reduce the initial render from 570ms to 320ms which accounts for a 56% decrease in rendering time