This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix scroll token for EventTile and EventListSummary node type#6154
Merged
Conversation
t3chguy
approved these changes
Jun 7, 2021
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regressed by #6079
Fixes element-hq/element-web#17567
Fixes element-hq/element-web#17579
Superseeds #6150 due to timing constraints
This fixes the
FilePaneland theNotificationPanelscrolling ensuring that the nodes there have the correctdata-scroll-tokensattribute set.It also ensures that all element are list item and that no other node types are a direct child of the
olelement for a11y reasons