This repository was archived by the owner on Sep 11, 2024. It is now read-only.
EventTilePreview fixes#6000
Merged
turt2live merged 8 commits intoJun 22, 2021
Merged
Conversation
Reduces the blurriness of avatars in the EventTilePreview. Signed-off-by: Robin Townsend <robin@robin.town>
MemberAvatar requires a display name, or else it refuses to render. Signed-off-by: Robin Townsend <robin@robin.town>
Member
Author
|
Also, PR 6000 ;) |
turt2live
suggested changes
May 11, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
otherwise looks sane, but we do need a comment of some kind for why we'd be dropping to a lower avatar size (risking blurry images)
Member
Author
|
Reverted the thumbnail size change as I wasn't aware that 32 is just the value that's used everywhere. This should just be the one bug fix for when the user doesn't have a display name, then |
It was a bullet point, since EventTiles now get created as li by default :P Signed-off-by: Robin Townsend <robin@robin.town>
Member
Author
|
Also removed the mystery dot added by #6154
|
Because of 91df392, we now need to additionally set rawDisplayName to properly fake our display name for an event. Signed-off-by: Robin Townsend <robin@robin.town>
turt2live
approved these changes
Jun 22, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Thank you! Apologies for the super delayed turnaround time on this...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a couple of things I noticed while referencing EventTilePreview code for #5999. (see commits)
Fixes element-hq/element-web#17621