This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix forward dialog message preview display names#6204
Merged
Conversation
Signed-off-by: Robin Townsend <robin@robin.town>
jryans
approved these changes
Jun 17, 2021
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Thanks, makes sense to me! 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of #5880 this is now needed in order to actually show the user's display name in the forward dialog message preview. (currently on develop all you get is your MXID) A similar fix for EventTilePreview is at #6000.