Transfer by Dialpad#6217
Conversation
Also moves more logic out of views and into callhandler via a dispatch First cut: UI not done yet, put in as a Tab View (the layout doesn't work at all and overlaps horribly).
Tab style is still wrong though
flexbox and calc()ed heights are not a winning combination, so stay consistent and use calc()ed heights throughout. Also, put the delete button back rather than implementing a different one of those too.
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
Otherwise looks good to me 👍
| }; | ||
|
|
||
| private onCancel = () => { | ||
| this.props.onFinished([]); |
There was a problem hiding this comment.
If I remember correctly, the first parameter of this onFinished callback is a boolean to notify whether the modal closed successfully or in an error state
There was a problem hiding this comment.
This one appears to be special and unique and gets passed the list of strings to invite instead... :/
| border-top: 0px; | ||
| border-left: 0px; | ||
| border-right: 0px; | ||
| border-radius: 0px; |
There was a problem hiding this comment.
Probably out of scope for this review, but we might want to introduce a StyleLint rule that forces unit-less 0.
It's what I usually see in CSS codebases
There was a problem hiding this comment.
oh yeah - have changed these, but yep, we could probably add a rule
Co-authored-by: Germain <germain@souquet.com>
|
@gaelledel design tweaks applied: I've update the first screenshot |
as float: right causes them to drop out of the box model so the the alignment messes up.
by passing a special wrapper class
|
@gsouquet re-requesting review as quite as lot has changed. Plan is now to merge this to a branch and make more changes to keep the PRs a manageable size for code review but merge once we've achieved the final design. |
… dbkr/transfer_by_dialpad
anoadragon453
force-pushed
the
dbkr/transfer_by_dialpad
branch
from
8a99166 to
91bc871
Compare
dbkr
changed the base branch from
develop
to
feature/transfer_dialpad_improvements
This PR builds on top of #6217. It aims to cover: Increasing the size of the dial pad in general. Spacing the number buttons out a bit more from each other. Shrinking the separator bar between the text entry field and number buttons.
3 participants
Adds a dial pad to the transfer dialog
Extends TabbedView to have a tabs-on-top view as well as tabs-on-left
The transfer dialog really needs to be split out of the invite dialog now, but that requires also splitting out the user search bit into its own component.
There are other general dial pad updates in the designs (adding letters, moving delete button to the text field) that I haven't done here because this PR is already sizeable.