Add dialpad to transfer dialog + various dialpad UI improvements#6363
Conversation
Co-authored-by: Germain <germain@souquet.com> Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
… feature/transfer_dialpad_improvements
This PR builds on top of #6217. It aims to cover: Increasing the size of the dial pad in general. Spacing the number buttons out a bit more from each other. Shrinking the separator bar between the text entry field and number buttons.
This PR adds letters and a + underneath the dial pad buttons.
… feature/transfer_dialpad_improvements
germain-gg
left a comment
There was a problem hiding this comment.
Mainly looks good to me! Thank you for working on that
Before merging that in develop could you extract all the hardcoded colour into _dark.scss, _legacy-dark.scss, _light.scss and _legacy-dark.scss
|
@anoadragon453 Did a design review already happen? I did not notice a green check from @gaelledel on the other PRs... |
|
Thanks for the review @gsouquet. It turns out all of those colours were already variables 😅. I noticed a few more instances of matrix-react-sdk/res/themes/legacy-dark/css/_legacy-dark.scss Lines 214 to 216 in 9ce041a
|
|
As far as I understand |
Actually is the base for all custom themes, not at all exclusive to Hardened Element https://github.com/vector-im/element-web/blob/develop/docs/theming.md#custom-themes https://github.com/aaronraimist/element-themes And is used as-is on some legacy customer deployments |
|
@gsouquet I think we should move this fix to another PR as we have a customer waiting on this PR landing. But thanks for the information both! |
This PR simply merges the feature branch
feature/transfer_dialpad_improvementsto develop. This branch is the combination of PRs #6217, #6301, #6325 and #6338, which have already been independently reviewed.See each linked PR for the details, but the high-level summary is that the call transfer dialog now has a built in dial pad for transferring a call to a number you can dial:
as well as various improvements to the dial pad itself such as better sizing, letters under the buttons and a better-placed backspace button:
Design by @gaelledel, implementation by @dbkr and myself.
Signed-off-by: Andrew Morgan <andrewm@element.io>