Catch exceptions from the widget driver in the event relations endpoint#73
Merged
robintown merged 2 commits intoSep 7, 2022
Merged
Conversation
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
dhenneke
requested review from
andybalaam,
robintown and
t3chguy
and removed request for
a team
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #72.
The driver can throw an exception, e.g. when the referenced event doesn't exist or when the user is not authorized to see it due to the configured history visibility rules. Without this change, the call times out because the error is not forwarded via the transport channel.