Implement MSC3869: Read event relations with the Widget API#72
Merged
Conversation
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
This was referenced Aug 22, 2022
dhenneke
requested review from
andybalaam,
kerryarchibald and
turt2live
and removed request for
a team
turt2live
reviewed
Aug 24, 2022
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Generally this looks pretty good to me, though I haven't reviewed the MSC as much as I probably should 😇
Passing to voip team to finalize review.
turt2live
requested review from
a team
and removed request for
andybalaam and
kerryarchibald
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
robintown
reviewed
Aug 26, 2022
Member
robintown
left a comment
robintown
left a comment
There was a problem hiding this comment.
This looks great, I just have a few minor comments
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
robintown
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See matrix-org/matrix-spec-proposals#3869 for more details.
This also sets up
jestand adds a GitHub workflow to lint the code and run tests.