Make getClientVersions public#74
Merged
Merged
Conversation
Signed-off-by: Oliver Sand <oliver.sand@nordeck.net>
Fox32
requested review from
duxovni,
florianduros and
justjanne
and removed request for
a team
duxovni
approved these changes
Oct 7, 2022
Contributor
Author
|
@florianduros @justjanne Anyone time for a review? |
florianduros
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
getClientVersionsfunction onWidgetApipublic and tests it.It is quite useful that the versions are exchanged between client and widget, so that the widget knows which capabilities the client has. But up to now, a widget can not access these details. We recently add #72 which evolves the API, but for now there is no way to detect whether it is really supported before running into errors. We would prefer to make a check and notify the user that he has to update to a newer Element version.