Skip to content

Draft blog post on Sydent typing#1110

Closed
DMRobertson wants to merge 15 commits into
masterfrom
dmr/sydent-typing
Closed

Draft blog post on Sydent typing#1110
DMRobertson wants to merge 15 commits into
masterfrom
dmr/sydent-typing

Conversation

@DMRobertson
Copy link
Copy Markdown
Contributor

@DMRobertson DMRobertson commented Nov 8, 2021 •
edited by github-actions Bot
Loading

TODO:

  • solicit feedback
  • rename files and image paths when we decide which date to post it

See https://pr1110--matrix-org-previews.netlify.app/blog/2021/11/08/type-coverage-for-sydent-lessons-learnt for a preview

Preview: https://pr1110--matrix-org-previews.netlify.app

David Robertson added 6 commits November 8, 2021 17:25
Draft blog post on Sydent typing
3bf8145 
TODO:
- preamble
- <figure>s at the bottom
- solicit feedback
- rename files and image paths when we decide which date to post it
Preamble
61ed17e
Quote colon
e4f9465
Maybe CI will work with an actual date?
55d77f7
Screw it, let's set the date to the 8th
3814fed
Update 2021-11-XX-sydent-typing.mdx
9299c5b
richvdh
richvdh reviewed Nov 15, 2021
View reviewed changes
Comment thread gatsby/content/blog/2021/11/2021-11-XX-sydent-typing.mdx Outdated
richvdh
richvdh reviewed Nov 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of typos I noticed!

Comment thread gatsby/content/blog/2021/11/2021-11-XX-sydent-typing.mdx Outdated
Comment thread gatsby/content/blog/2021/11/2021-11-XX-sydent-typing.mdx Outdated
@richvdh
Typo fixes, thanks Rich
36429fe 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@DMRobertson DMRobertson requested a review from callahad November 16, 2021 10:48
afranke
afranke reviewed Nov 16, 2021
View reviewed changes
Comment thread gatsby/content/blog/2021/11/2021-11-XX-sydent-typing.mdx Outdated
afranke
afranke reviewed Nov 17, 2021
View reviewed changes
Comment thread gatsby/content/blog/2021/11/2021-11-XX-sydent-typing.mdx Outdated
David Robertson and others added 3 commits November 17, 2021 12:02
@afranke
typo fix own -> down
933d9eb 
Co-authored-by: Alexandre Franke <alexandre.franke@gmail.com>
fix linebreak
88aa7eb
fix syntax highlighting?
a748b21
afranke
afranke reviewed Nov 18, 2021
View reviewed changes
Comment thread gatsby/content/blog/2021/11/2021-11-XX-sydent-typing.mdx Outdated
@afranke
Copy link
Copy Markdown
Contributor

afranke commented Nov 18, 2021 •
edited
Loading

This is quite long. Firefox read mode estimates a 45-57 minutes read time. I’m worried that readers might find it too difficult to digest in one go (and possibly forget to come back to it if they decide to take a break from it). Have you considered turning it into a small series?

afranke
afranke reviewed Nov 18, 2021
View reviewed changes
Comment thread gatsby/content/blog/2021/11/2021-11-XX-sydent-typing.mdx Outdated
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Nov 18, 2021

This is quite long. Firefox read mode estimates a 45-57 minutes read time. I’m worried that readers might find it too difficult to digest in one go (and possibly forget to come back to it if they decide to take a break from it). Have you considered turning it into a small series?

I had exactly this thought. @DMRobertson: there's a lot of great stuff here, but I do worry it's an epic read. I think it would make a great series.

@DMRobertson
Copy link
Copy Markdown
Contributor Author

DMRobertson commented Nov 19, 2021

Thanks both for your thoughts. I'm happy to chop this up; hopefully I can find some time to do so in the next week or so.

Chop up into three posts
c7b86af 
Rough. Needs a re-read and needs some word glue between parts 2 and 3.
@DMRobertson
Copy link
Copy Markdown
Contributor Author

DMRobertson commented Nov 25, 2021

I've spent a little time chopping this up into three posts. I hope to find some more time tomorrow to give it another pass---I did some reordering, so I think some more glue prose might be needed.

David Robertson added 3 commits November 26, 2021 11:31
Fix typos spotted by AF
cc6fc5c
Another pass at making the parts flow together.
f1fcc6f
Change dates to release on upcoming Fridays
557609f 
except this won't actually work because Gatsby is static, so I'll have
to probably chop this up into smaller PRs
@DMRobertson
Copy link
Copy Markdown
Contributor Author

DMRobertson commented Nov 26, 2021

Probably makes sense to chop this up into three separate PRs. Thanks all for your input; I'll do that now.

This was referenced Nov 26, 2021
Merged
Merged
@DMRobertson DMRobertson mentioned this pull request Nov 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richvdh richvdh richvdh left review comments

@callahad callahad Awaiting requested review from callahad

+1 more reviewer

@afranke afranke afranke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DMRobertson @afranke @richvdh