Sydent typing, part 3#1125
Merged
Merged
Conversation
This was referenced Nov 26, 2021
Merged
Merged
H-Shay
reviewed
Dec 1, 2021
H-Shay
reviewed
Dec 1, 2021
|
I said this on the other ones but I'll say it again: fantastic job! I wonder if you could get this published on mypy's blog, or the like-I am sure people will find it helpful so the more eyes on it the better. Thanks for taking the time to do such a thorough write-up, I definitely learned things. |
Co-authored-by: Shay <hillerys@element.io>
DMRobertson
force-pushed
the
dmr/sydent-typing-3
branch
from
4d6b483 to
d3d5a1a
Compare
added 3 commits
December 16, 2021 12:24
They're not going to work on netlify, but screw it
callahad
reviewed
Dec 16, 2021
| - the proportion of "imprecise" lines across the project; I also used the complement, `precision = 100% - imprecision`, and | ||
| - the proportion of expressions whose type is not `Any`. | ||
|
|
||
| These are plotted in the graph at the top of this writeup. I could see that precision and the proportion of typed expressions were correlated, but I didn't understand how they differed. I couldn't see an explanation in the mypy docs, so I went [digging](https://github.com/python/mypy/blob/d807e097d142a88a48af93314d15ad87e41d2f19/mypy/stats.py) into the mypy source code. My understanding is as follows. |
There was a problem hiding this comment.
The plot is in the first post, now. Link to it?
callahad
reviewed
Dec 16, 2021
callahad
reviewed
Dec 16, 2021
callahad
reviewed
Dec 16, 2021
Co-authored-by: Dan Callahan <danc@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last bit of #1110. Back references #1123 and #1124.
Tentatively scheduled for Dec 17th.
Should be previewable at https://pr1125--matrix-org-previews.netlify.app/blog/2021/12/17/type-coverage-for-sydent-evaluation
Preview: https://pr1125--matrix-org-previews.netlify.app