This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Revert the deletion of stale devices due to performance issues.#14662
Merged
Conversation
reivilibre
changed the title
DMRobertson
approved these changes
Dec 12, 2022
Contributor
DMRobertson
left a comment
DMRobertson
left a comment
There was a problem hiding this comment.
Do we understand the perf problems from the this version of the patch?
Contributor
Author
No, afraid that knowledge is likely locked up in Erik's head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows: #14649, #14595
Unfortunately the new feature that deletes stale devices (to try and prevent performance problems as they accumulate) has been giving us performance problems.
I propose that we revert it for now because it'd be too risky to try and make minor tweaks to it and still release it right before xmas.
Original commit schedule, with full messages:
Revert "Limit the number of devices we delete at once (Limit the number of devices we delete at once #14649)"
This reverts commit 94bc21e.
Revert "Delete stale non-e2e devices for users, take 2 (Delete stale non-e2e devices for users, take 2 #14595)"
This reverts commit c2de2ca.