This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Delete stale non-e2e devices for users, take 2#14595
Merged
Merged
Conversation
erikjohnston
force-pushed
the
erikj/delete_devices
branch
from
707535e to
e92495f
Compare
This should help reduce the number of devices e.g. simple bots the repeatedly login rack up. We only delete non-e2e devices as they should be safe to delete, whereas if we delete e2e devices for a user we may accidentally break their ability to receive e2e keys for a message. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
…andling users with more than 50 non-E2E devices (#14580)
erikjohnston
force-pushed
the
erikj/delete_devices
branch
from
e92495f to
838380c
Compare
clokep
reviewed
Dec 6, 2022
Comment on lines
+465
to
+468
| # We don't want to block and try and delete tonnes of devices at once, | ||
| # so we cap the number of devices we delete synchronously. | ||
| first_batch, remaining_device_ids = device_ids[:10], device_ids[10:] | ||
| await self.delete_devices(user_id, first_batch) |
Member
There was a problem hiding this comment.
Why not delete them all in the background?
Member
Author
There was a problem hiding this comment.
I was mainly thinking that it's nice to delete some devices before we let someone create a new one, so that we know every log in we delete at least some of the stale devices.
I don't really think it matters much in hindsight though.
squahtx
approved these changes
Dec 8, 2022
Contributor
squahtx
left a comment
squahtx
left a comment
There was a problem hiding this comment.
Looks good!
The cache to deduplicate the deletions is an interesting trick.
anoadragon453
added a commit
that referenced
this pull request
Dec 9, 2022
This reverts commit c2de2ca.
erikjohnston
added a commit
that referenced
this pull request
Dec 9, 2022
…"" This reverts commit 694a3fd.
reivilibre
added a commit
that referenced
this pull request
Dec 12, 2022
This reverts commit c2de2ca.
erikjohnston
added a commit
that referenced
this pull request
Mar 2, 2023
This should help reduce the number of devices e.g. simple bots the repeatedly login rack up. We only delete non-e2e devices as they should be safe to delete, whereas if we delete e2e devices for a user we may accidentally break their ability to receive e2e keys for a message.
erikjohnston
added a commit
that referenced
this pull request
Mar 2, 2023
This should help reduce the number of devices e.g. simple bots the repeatedly login rack up. We only delete non-e2e devices as they should be safe to delete, whereas if we delete e2e devices for a user we may accidentally break their ability to receive e2e keys for a message.
erikjohnston
added a commit
that referenced
this pull request
Mar 2, 2023
This should help reduce the number of devices e.g. simple bots the repeatedly login rack up. We only delete non-e2e devices as they should be safe to delete, whereas if we delete e2e devices for a user we may accidentally break their ability to receive e2e keys for a message.
erikjohnston
added a commit
that referenced
this pull request
Mar 2, 2023
This should help reduce the number of devices e.g. simple bots the repeatedly login rack up. We only delete non-e2e devices as they should be safe to delete, whereas if we delete e2e devices for a user we may accidentally break their ability to receive e2e keys for a message.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reintroduced #14038 and #14580, that were reverted in #14582.
The fix to the issue is to limit the number of devices we try and delete at once, and punt deleting the majority of devices to a background job.