This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Delete stale non-e2e devices for users, take 3#15183
Merged
Merged
Conversation
erikjohnston
force-pushed
the
erikj/delete_devices3
branch
from
9b7ce98 to
dd45814
Compare
This should help reduce the number of devices e.g. simple bots the repeatedly login rack up. We only delete non-e2e devices as they should be safe to delete, whereas if we delete e2e devices for a user we may accidentally break their ability to receive e2e keys for a message.
erikjohnston
force-pushed
the
erikj/delete_devices3
branch
from
dd45814 to
cb63591
Compare
clokep
reviewed
Mar 2, 2023
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
clokep
reviewed
Mar 6, 2023
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Member
Author
|
Waiting to merge this until we are ready to put this on matrix.org, as previous iterations of this change have caused production issues. |
erikjohnston
added a commit
that referenced
this pull request
Mar 29, 2023
erikjohnston
added a commit
that referenced
this pull request
Mar 29, 2023
erikjohnston
added a commit
that referenced
this pull request
Mar 31, 2023
This reverts commit 78cdb72.
erikjohnston
added a commit
that referenced
this pull request
Mar 31, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help reduce the number of devices e.g. simple bots the repeatedly login rack up.
We only delete non-e2e devices as they should be safe to delete, whereas if we delete e2e devices for a user we may accidentally break their ability to receive e2e keys for a message.
Basically #14595, but makes sure that we only have one delete going per-person at a time, and with a longer timeout.