This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add a Postgres REPLICA IDENTITY to tables that do not have an implicit one. This should allow use of Postgres logical replication. (take 2, now with no added deadlocks!)#16658
Merged
Conversation
We can't combine them into one file as it makes it likely to hit a deadlock if Synapse is running, as it only takes one other transaction to access two tables in a different order to the schema delta.
reivilibre
changed the title
REPLICA IDENTITY to tables that do not have an implicit one. This should allow use of Postgres logical replication.REPLICA IDENTITY to tables that do not have an implicit one. This should allow use of Postgres logical replication. (take 2, now with no added deadlocks!)
clokep
approved these changes
Nov 29, 2023
Member
clokep
left a comment
clokep
left a comment
There was a problem hiding this comment.
Looks like you split some stuff into separate files. 😄
DMRobertson
pushed a commit
that referenced
this pull request
Dec 5, 2023
This reverts two commits:
0bb8e41
"Fix postgres schema after dropping old tables (#16730)"
and
51e4e35
"Add a Postgres `REPLICA IDENTITY` to tables that do not have an implicit one. This should allow use of Postgres logical replication. (take 2, now with no added deadlocks!) (#16658)"
and also amends the changelog.
|
Is there some background on why this commit got reverted? I've been waiting with bated breath for weeks on getting it committed. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #16224
Supersedes: #16456, #16647
Base:
developOriginal commit schedule, with full messages:
Add
ALTER TABLE ... REPLICA IDENTITY ...for individual tablesWe can't combine them into one file as it makes it likely to hit a deadlock
if Synapse is running, as it only takes one other transaction to access two
tables in a different order to the schema delta.
Add notes