This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix postgres schema after dropping old tables#16730
Merged
Merged
Conversation
added 2 commits
December 5, 2023 10:29
Collaborator
|
Aha, this is why #16729 is failing. Thanks! |
Contributor
Author
|
The migrations I deleted should correspond exactly to the tables in this delta: synapse/synapse/storage/schema/main/delta/83/01_drop_old_tables.sql Lines 16 to 24 in 579c6be |
reivilibre
approved these changes
Dec 5, 2023
DMRobertson
pushed a commit
that referenced
this pull request
Dec 5, 2023
This reverts two commits:
0bb8e41
"Fix postgres schema after dropping old tables (#16730)"
and
51e4e35
"Add a Postgres `REPLICA IDENTITY` to tables that do not have an implicit one. This should allow use of Postgres logical replication. (take 2, now with no added deadlocks!) (#16658)"
and also amends the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a conflict between
#16658 and #16652
and should unsad CI.