This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Implement server side of MSC1794 - Federation v2 Invite API#4402
Merged
Conversation
Member
Author
|
The error looks to be a race/bug that wasn't introduced by this PR, so can be ignored as I'll fix it separately |
Codecov Report
@@ Coverage Diff @@
## develop #4402 +/- ##
===========================================
+ Coverage 73.64% 73.66% +0.01%
===========================================
Files 300 300
Lines 29789 29801 +12
Branches 4896 4896
===========================================
+ Hits 21938 21952 +14
+ Misses 6411 6409 -2
Partials 1440 1440 |
…d_v2_invite_server
Member
Author
|
See matrix-org/sytest#545 for tests |
turt2live
added a commit
to matrix-org/matrix-spec-proposals
that referenced
this pull request
Jan 29, 2019
Original proposal: #1794 Implementation proofs: * matrix-org/synapse#4402 * matrix-org/synapse#4496 There are no changes from the original proposal.
turt2live
added a commit
to matrix-org/matrix-spec-proposals
that referenced
this pull request
Jan 29, 2019
Original proposal: #1794 Implementation proofs: * matrix-org/synapse#4402 * matrix-org/synapse#4496 There are no changes from the original proposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MSC hasn't been merged yet, but is in FCP. We can always change the implementation in the (unlikely?) event the MSC changes.
Based on #4390