This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Implement tracking event format versions#4403
Closed
erikjohnston wants to merge 9 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4403 +/- ##
===========================================
+ Coverage 73.64% 73.65% +<.01%
===========================================
Files 300 300
Lines 29801 29837 +36
Branches 4896 4901 +5
===========================================
+ Hits 21947 21975 +28
- Misses 6417 6418 +1
- Partials 1437 1444 +7 |
richvdh
suggested changes
Jan 17, 2019
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
looks generally plausible I guess, though I'm generally having trouble keeping all the state for a +199 -83 patch in my head at once :/
| if room_version in { | ||
| RoomVersions.V1, | ||
| RoomVersions.V2, | ||
| RoomVersions.VDH_TEST, |
Member
There was a problem hiding this comment.
we should consider dropping these test versions imho
erikjohnston
force-pushed
the
erikj/event_format_version
branch
from
0d00293 to
3a396c7
Compare
erikjohnston
force-pushed
the
erikj/event_format_version
branch
from
5e86c36 to
be2f648
Compare
Member
Author
|
This has been superseded by #4451 and co. |
This was referenced Jan 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in two parts:
Based on #4390 and #4402