Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Add support for persisting event format versions#4437

Merged
erikjohnston merged 4 commits into
developfrom
erikj/event_format_version_v2
Jan 24, 2019
Merged

Add support for persisting event format versions#4437
erikjohnston merged 4 commits into
developfrom
erikj/event_format_version_v2

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

Currently we only have the one event format version defined, but this
adds the necessary infrastructure to persist and fetch the format
versions alongside the events.

We specify the format version rather than the room version as:

  1. We don't necessarily know the room version, existing events may be
    either v1 or v2.
  2. We'd need to be careful to prevent/handle correctly if different
    events in the same room reported to be of different versions, which
    sounds annoying.

Currently we only have the one event format version defined, but this
adds the necessary infrastructure to persist and fetch the format
versions alongside the events.

We specify the format version rather than the room version as:

1. We don't necessarily know the room version, existing events may be
   either v1 or v2.
2. We'd need to be careful to prevent/handle correctly if different
   events in the same room reported to be of different versions, which
   sounds annoying.
@erikjohnston erikjohnston force-pushed the erikj/event_format_version_v2 branch from f3234e0 to 4cd50d9 Compare January 23, 2019 11:30
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 23, 2019

Codecov Report

Merging #4437 into develop will increase coverage by 0.04%.
The diff coverage is 71.42%.

@@             Coverage Diff             @@
##           develop    #4437      +/-   ##
===========================================
+ Coverage    73.58%   73.63%   +0.04%     
===========================================
  Files          301      302       +1     
  Lines        29822    29824       +2     
  Branches      4894     4896       +2     
===========================================
+ Hits         21946    21962      +16     
+ Misses        6446     6429      -17     
- Partials      1430     1433       +3

@erikjohnston
Copy link
Copy Markdown
Member Author

This is split out from #4403. I've addressed the review comments that were there, including moving delta file to 53, and adding back in the imports used for auto completion, and generally killed spurious changes.

Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit 664b7a2 into develop Jan 24, 2019
@erikjohnston erikjohnston deleted the erikj/event_format_version_v2 branch March 5, 2019 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants