This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add support for persisting event format versions#4437
Merged
Conversation
Currently we only have the one event format version defined, but this adds the necessary infrastructure to persist and fetch the format versions alongside the events. We specify the format version rather than the room version as: 1. We don't necessarily know the room version, existing events may be either v1 or v2. 2. We'd need to be careful to prevent/handle correctly if different events in the same room reported to be of different versions, which sounds annoying.
f3234e0 to
4cd50d9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4437 +/- ##
===========================================
+ Coverage 73.58% 73.63% +0.04%
===========================================
Files 301 302 +1
Lines 29822 29824 +2
Branches 4894 4896 +2
===========================================
+ Hits 21946 21962 +16
+ Misses 6446 6429 -17
- Partials 1430 1433 +3 |
Member
Author
|
This is split out from #4403. I've addressed the review comments that were there, including moving delta file to 53, and adding back in the imports used for auto completion, and generally killed spurious changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we only have the one event format version defined, but this
adds the necessary infrastructure to persist and fetch the format
versions alongside the events.
We specify the format version rather than the room version as:
either v1 or v2.
events in the same room reported to be of different versions, which
sounds annoying.