Full test for lazy loading members#445
Merged
Merged
Conversation
14 tasks
ara4n
changed the title
Member
Author
|
The tests are failing as this is building against the wrong branch (it should be matrix-org/synapse#3331, not matrix-org/synapse#2970) |
Member
Author
|
i'm going to assume this has been lgtm'd given #2970 was. |
Member
Author
|
actually, i guess there's no harm in getting an explicit lgtm from @richvdh |
Member
|
if you're awaiting a review, it's helpful to stick it in the queue... and yes, it has not been lgtmed yet |
Member
|
merging this so that I can review #467 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired by with matrix-org/synapse#3331