Redundant lazy members test#467
Merged
Merged
Conversation
3 tasks
Member
Author
|
@matrixbot retest this please |
richvdh
approved these changes
Jul 26, 2018
| # Alice syncs again; she should not see any membership events as | ||
| # the redundant ones for Bob and Charlie are removed. | ||
|
|
||
| # TODO: speed up time and check that if we wait an hour then the server's |
Member
There was a problem hiding this comment.
isn't this an implementation issue? servers can keep the cache for as long or as short as they want?
Member
or rather, I'd like to see synapse doing more validation, and I'd like to see sytest doing more validation of that validation. but I'm not going to insist on it for now. |
Member
Author
|
done |
richvdh
approved these changes
Jul 26, 2018
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
even better, modulo duplication?
feel free to merge after fixing
| matrix_create_filter( $alice, { | ||
| room => { | ||
| state => { | ||
| lazy_load_members => "true", |
Member
There was a problem hiding this comment.
isn't this the same as line 13?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests matrix-org/synapse#3331
(also includes #445)