Tests for room version upgrades#513
Merged
Merged
Conversation
Member
Author
|
@matrixbot retest this please |
richvdh
force-pushed
the
rav/room_version_upgrades
branch
from
d9db930 to
f969e0d
Compare
This was referenced Oct 26, 2018
richvdh
force-pushed
the
rav/room_version_upgrades
branch
from
41b12b2 to
f969e0d
Compare
erikjohnston
approved these changes
Oct 29, 2018
| Future->done( $body ); | ||
| }); | ||
| } | ||
| push @EXPORT, qw/expect_matrix_error/; |
Member
There was a problem hiding this comment.
Do we not normally do qw( ... )?
| my $f = shift; | ||
| my ( $f, $expected_errcode, %opts ) = @_; | ||
|
|
||
| my $expected_http_code = $opts{http_code} // 400; |
Member
There was a problem hiding this comment.
I think it would be clearer to always require the HTTP code, so it becomes something like:
)->expect_matrix_error(418, 'M_EXPECTED_ERROR')
Member
Author
|
Bah, this is now failing CI because matrix-org/synapse#4099 has landed and changed the way things work. |
This should mean we can reduce some boilerplate in some of the other tests.
Member
Author
|
Erik could you have another look at this now that I've refactored the world? |
erikjohnston
approved these changes
Oct 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests for matrix-org/synapse#4091
builds on top of #514