Test moving aliases on room upgrades#517
Merged
Merged
Conversation
erikjohnston
requested changes
Oct 29, 2018
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
Looks good apart from the boiler plate code to wait for canonical alias to come down sync. It'd be good to find a way to reduce that in both this PR and the other
| new_version => $new_version, | ||
| }, | ||
| )->then( sub { | ||
|
|
Member
There was a problem hiding this comment.
(Did you mean to add these new lines?)
| } | ||
| return 1; | ||
| }, | ||
| ); |
Member
There was a problem hiding this comment.
(This feels sad the amount of boiler plate code here)
| matrix_get_room_state( | ||
| $creator, $room_id, | ||
| type=>'m.room.aliases', state_key=>$server_name, | ||
| ); |
Member
There was a problem hiding this comment.
Any reason for using matrix_get_room_state rather than just syncing?
Member
Author
There was a problem hiding this comment.
I decided it was going to be a pain to find the right events in the sync. Could change it though.
erikjohnston
approved these changes
Oct 31, 2018
richvdh
force-pushed
the
rav/aliases_for_upgrades
branch
from
3c084da to
6a6653a
Compare
Member
Author
|
sigh. retest this please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #513. Tests for matrix-org/synapse#4101.