Generalise validate_email_for_user to work for other /requestToken endpoints#710
Merged
Merged
Conversation
…dpoints Additionally remove the requirement for a parameter to be required, as none of the /requestToken endpoints require authentication.
anoadragon453
changed the title
richvdh
approved these changes
Sep 26, 2019
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
lgtm.
The only thing I would have suggested would be to use a %params hash for named params since (a) it would let you give a sensible default for path (b) once you get to four params things start getting tricky to keep track of. But it's not a big deal
Member
Author
|
I'll leave it out for now, but I'll keep that in mind :) |
anoadragon453
added a commit
that referenced
this pull request
Mar 18, 2020
…ase-v1.5.0 * origin/release-v1.5.1: Update test to work with more room versions (#725) Update sytest scripts with correct format_tap.pl location (#727) Buildkite annotations for dendrite (#715) Ability to join a room using a given server_name (#726) Add Perl results.tap parser (#714) Better error when /send fails (#724) Make `send_and_await_event` pass params to `create_event` (#723) Enable testing of log contexts for synapse ensure that server ACLs are enforced (#717) Regression test for sync cache consistency bug (#718) Update a test to give better diagnostics (#719) Fix race in email validation test Update a number of tests to check non-v1 rooms (#716) Improve the log_if_fail diagnostics for public rooms list test (#713) Support validating msisdns with the identity server (#712) Move MTA methods from 12login to 11register (#711) Generalise validate_email_for_user to work for other /requestToken endpoints (#710) Remove reference to CircleCI in Dendrite's sytest script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up during implementation of #695. Registration calls the
/r0/register/email/requestTokenpath rather than/account/3pid/email/requestToken.Additionally remove the requirement for a $user parameter to be required, as none of the /requestToken endpoints require authentication.