Skip to content

Add Perl results.tap parser#714

Merged
anoadragon453 merged 7 commits into
developfrom
anoa/format_tap_perl
Oct 22, 2019
Merged

Add Perl results.tap parser#714
anoadragon453 merged 7 commits into
developfrom
anoa/format_tap_perl

Conversation

@anoadragon453
Copy link
Copy Markdown
Member

The aim of this is to replace the format_tap.py file that's required to show the following Buildkite annotation for failed Sytest tests:

image

This perl script generates a line-for-line same output as the python version. This is useful so that we don't need to include a python binary for Dendrite's sytest environment.

Comment thread format_tap.pl Outdated
Comment thread format_tap.pl Outdated
Comment thread format_tap.pl Outdated
Comment thread format_tap.pl Outdated
Comment thread format_tap.pl Outdated
@erikjohnston
Copy link
Copy Markdown
Member

Also, why isn't this killing off the old script? Lets not keep both.

@anoadragon453
Copy link
Copy Markdown
Member Author

Also, why isn't this killing off the old script? Lets not keep both.

The old script is in Synapse's repo. I need to make a PR for it and changing the CI.

@erikjohnston
Copy link
Copy Markdown
Member

At least you can change the synapse_sytest script to use this?

@erikjohnston
Copy link
Copy Markdown
Member

Also, please don't put this in the root of the repo

anoadragon453 and others added 5 commits October 19, 2019 00:10
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anoadragon453 anoadragon453 merged commit 8aa35ba into develop Oct 22, 2019
@anoadragon453 anoadragon453 deleted the anoa/format_tap_perl branch October 22, 2019 17:02
anoadragon453 added a commit that referenced this pull request Oct 23, 2019
Generate annotations using the perl script from #714 

Also copied some nice logging from Synapse's script.

Requires #714
anoadragon453 added a commit that referenced this pull request Oct 23, 2019
Whoops, the location of this file changed during the course of #714 and #715 wasn't updated to match.

This PR changes the sytest script to use the new location.
anoadragon453 added a commit that referenced this pull request Mar 18, 2020
…ase-v1.5.0

* origin/release-v1.5.1:
  Update test to work with more room versions (#725)
  Update sytest scripts with correct format_tap.pl location (#727)
  Buildkite annotations for dendrite (#715)
  Ability to join a room using a given server_name (#726)
  Add Perl results.tap parser (#714)
  Better error when /send fails (#724)
  Make `send_and_await_event` pass params to `create_event` (#723)
  Enable testing of log contexts for synapse
  ensure that server ACLs are enforced (#717)
  Regression test for sync cache consistency bug (#718)
  Update a test to give better diagnostics (#719)
  Fix race in email validation test
  Update a number of tests to check non-v1 rooms (#716)
  Improve the log_if_fail diagnostics for public rooms list test (#713)
  Support validating msisdns with the identity server (#712)
  Move MTA methods from 12login to 11register (#711)
  Generalise validate_email_for_user to work for other /requestToken endpoints (#710)
  Remove reference to CircleCI in Dendrite's sytest script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants