Have frontend proxy persist events when using redis#870
Merged
Conversation
anoadragon453
approved these changes
May 18, 2020
erikjohnston
force-pushed
the
erikj/move_events
branch
from
438fa97 to
705d037
Compare
Member
Author
|
There have been quite a few changes here... |
anoadragon453
approved these changes
Jun 2, 2020
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Sorry for taking a while to get to this. The new changes look great from a stability standpoint, and the additional logging is appreciated!
|
|
||
| # sending 50 messages can take a while | ||
| timeout => 20000, | ||
| timeout => 20, |
Member
There was a problem hiding this comment.
Has this made tests go faster or was this just an unnecessarily large number to begin with?
Member
Author
There was a problem hiding this comment.
Ah, I forgot about these. I think there was a confusion for the units here, they're in seconds not milliseconds (a timeout of 6 hours seems excessive).
richvdh
changed the title
anoadragon453
added a commit
that referenced
this pull request
Jun 24, 2020
…insic-release-v1.15.x * 'release-v1.15.0' of github.com:matrix-org/sytest: Use the standardized form for SSO login via user interactive auth. (#884) Add tests for room version 6. (#869) Add a retry_until_success around room join (#882) Have frontend proxy persist events when using redis (#870) Squashed commit of the following: Fix link to Synapse's contributing docs. (#879)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: matrix-org/synapse#7517
I chose to use frontend proxy rather than the event creator to ensure we test the HTTP replication routing. (We could use a new worker, but that is surprisingly faffy)