This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add option to move event persistence off master#7517
Merged
Conversation
erikjohnston
force-pushed
the
erikj/move_events
branch
from
acfca78 to
86b1d75
Compare
anoadragon453
suggested changes
May 18, 2020
anoadragon453
approved these changes
May 18, 2020
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
lgtm, take or leave the nit :)
This also means adding a replication API to call it from other instances.
erikjohnston
force-pushed
the
erikj/move_events
branch
from
1f5b3a4 to
8b02186
Compare
erikjohnston
force-pushed
the
erikj/move_events
branch
4 times, most recently
from
0e58aaf to
f1589f0
Compare
erikjohnston
force-pushed
the
erikj/move_events
branch
from
f1589f0 to
76bf9cf
Compare
Member
Author
|
The commits are mostly me sorting out a bad merge. The test failure is a flakey sytest that I'm dealing with separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds config of the form:
(Better names for config option would be appreciated).
Requires #7515
and #7516