Skip to content

Some minor cleanups to the startup scripts#926

Merged
richvdh merged 1 commit into
developfrom
rav/script_cleanups
Aug 5, 2020
Merged

Some minor cleanups to the startup scripts#926
richvdh merged 1 commit into
developfrom
rav/script_cleanups

Conversation

@richvdh
Copy link
Copy Markdown
Member

@richvdh richvdh commented Aug 5, 2020

No description provided.

@richvdh richvdh requested a review from a team August 5, 2020 17:42
@richvdh richvdh force-pushed the rav/script_cleanups branch from 6db57dc to 4117923 Compare August 5, 2020 17:45
Comment thread docker/base.Dockerfile
# (we expect the docker build context be the sytest repo root, rather than the `docker` folder)
ADD install-deps.pl ./install-deps.pl
ADD cpanfile ./cpanfile
RUN dos2unix ./cpanfile ./install-deps.pl
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure these are redundant: these files don't have dos line endings.

Comment thread scripts/synapse_sytest.sh
echo "full_page_writes = off" >> "$PGDATA/postgresql.conf"

# Start the database
su -c 'eatmydata /usr/lib/postgresql/*/bin/pg_ctl -w -D $PGDATA start' postgres
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-D $PGDATA is the default.

Comment thread scripts/synapse_sytest.sh
# Start the database
su -c 'eatmydata /usr/lib/postgresql/*/bin/pg_ctl -w -D $PGDATA start' postgres
echo "starting postgres..."
su -c 'eatmydata /usr/lib/postgresql/*/bin/pg_ctl -w start -s' postgres
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"-s" is "silent", to get rid of the misleading "starting server" output.

Copy link
Copy Markdown
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@richvdh richvdh merged commit f7db295 into develop Aug 5, 2020
@richvdh richvdh deleted the rav/script_cleanups branch August 5, 2020 22:09
anoadragon453 added a commit that referenced this pull request Oct 21, 2020
…c_release_1_21_x

* origin/release-v1.20.1: (27 commits)
  Pin Alien::Sodium to an old version, to fix install errors (#949)
  Disable rate limiting on Dendrite (#947)
  Wait for synapse to start by using sd_notify. (#943)
  Fix bad tests (#939)
  Add ability to exclude tests for deprecated endpoints (#881)
  Abide by the spec when making /keys/query requests
  When putting device keys, may the JSON body spec compliant
  Remove trailing slashes from /state_ids and /backfill in ACL tests (#936)
  Fix /send server ACL test to match spec (#935)
  Call matrix_get_e2e_keys correctly
  Removed unused params from pydron invocation (#931)
  Deflake 'Server correctly resyncs when server leaves and rejoins a room' (#932)
  Dendrite configuration format v1 (#921)
  Disable TLS validation for Dendrite
  Set Dendrite loglevel to trace (#933)
  Merge Synapse::ViaHaproxy and -I Synapse::Dendron (#930)
  Use ProcessManager in Synapse.pm (#929)
  Add redis support to synapse docker image (#928)
  Update the README for the docker images (#927)
  Some minor cleanups to the startup scripts (#926)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants