Use ProcessManager in Synapse.pm#929
Merged
Merged
Conversation
Factor out some magical code in `HomeServer::Synapse`, replacing it with the more generic code we already have.
richvdh
commented
Aug 5, 2020
|
|
||
| =cut | ||
|
|
||
| sub kill_and_await_finish |
Member
Author
There was a problem hiding this comment.
this is now provided by SyTest::Homeserver::ProcessManager, so doesn't need a dummy implementation here.
clokep
approved these changes
Aug 6, 2020
Member
clokep
left a comment
clokep
left a comment
There was a problem hiding this comment.
I'm fairly certain that this is fine. I'm guessing some of this code existed for Synapse first and then got abstracted?
Member
Author
|
yeah, I think so. |
anoadragon453
added a commit
that referenced
this pull request
Oct 21, 2020
…c_release_1_21_x * origin/release-v1.20.1: (27 commits) Pin Alien::Sodium to an old version, to fix install errors (#949) Disable rate limiting on Dendrite (#947) Wait for synapse to start by using sd_notify. (#943) Fix bad tests (#939) Add ability to exclude tests for deprecated endpoints (#881) Abide by the spec when making /keys/query requests When putting device keys, may the JSON body spec compliant Remove trailing slashes from /state_ids and /backfill in ACL tests (#936) Fix /send server ACL test to match spec (#935) Call matrix_get_e2e_keys correctly Removed unused params from pydron invocation (#931) Deflake 'Server correctly resyncs when server leaves and rejoins a room' (#932) Dendrite configuration format v1 (#921) Disable TLS validation for Dendrite Set Dendrite loglevel to trace (#933) Merge Synapse::ViaHaproxy and -I Synapse::Dendron (#930) Use ProcessManager in Synapse.pm (#929) Add redis support to synapse docker image (#928) Update the README for the docker images (#927) Some minor cleanups to the startup scripts (#926) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bunch of magical code in
HomeServer::Synapsefor starting and monitoring processes. Replace this with the generic implementation inProcessManager.