Skip to content

update#3

Merged
fzhulitov merged 5 commits intombk-dev:masterfrom
fzhulitov:master
Jan 12, 2023
Merged

update#3
fzhulitov merged 5 commits intombk-dev:masterfrom
fzhulitov:master

Conversation

@fzhulitov
Copy link
Collaborator

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 11, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 5.61%.

Quality metrics Before After Change
Complexity 0.68 ⭐ 0.92 ⭐ 0.24 👎
Method Length 48.25 ⭐ 65.25 🙂 17.00 👎
Working memory 5.74 ⭐ 6.42 🙂 0.68 👎
Quality 78.97% 73.36% 🙂 -5.61% 👎
Other metrics Before After Change
Lines 42 49 7
Changed files Quality Before Quality After Quality Change
boe/kr.py 97.17% ⭐ 83.30% ⭐ -13.87% 👎
boe/request_data.py 74.12% 🙂 70.05% 🙂 -4.07% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
boe/request_data.py get_data_frame 1 ⭐ 169 😞 7 🙂 66.64% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sourcery-ai sourcery-ai bot mentioned this pull request Jan 11, 2023
@fzhulitov fzhulitov merged commit 7567a3f into mbk-dev:master Jan 12, 2023
fzhulitov added a commit that referenced this pull request Jan 12, 2023
Merge pull request #3 from fzhulitov/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant