Skip to content

update (Sourcery refactored)#4

Closed
sourcery-ai[bot] wants to merge 6 commits intomasterfrom
sourcery/pull-3
Closed

update (Sourcery refactored)#4
sourcery-ai[bot] wants to merge 6 commits intomasterfrom
sourcery/pull-3

Conversation

@sourcery-ai
Copy link

@sourcery-ai sourcery-ai bot commented Jan 11, 2023

Pull Request #3 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/mbk-dev/boe pull/3/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from fzhulitov January 11, 2023 14:23
@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jan 11, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 5.61%.

Quality metrics Before After Change
Complexity 0.68 ⭐ 0.92 ⭐ 0.24 👎
Method Length 48.25 ⭐ 65.25 🙂 17.00 👎
Working memory 5.74 ⭐ 6.42 🙂 0.68 👎
Quality 78.97% 73.36% 🙂 -5.61% 👎
Other metrics Before After Change
Lines 42 49 7
Changed files Quality Before Quality After Quality Change
boe/kr.py 97.17% ⭐ 83.30% ⭐ -13.87% 👎
boe/request_data.py 74.12% 🙂 70.05% 🙂 -4.07% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
boe/request_data.py get_data_frame 1 ⭐ 169 😞 7 🙂 66.64% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sourcery-ai sourcery-ai bot closed this Jan 12, 2023
@sourcery-ai sourcery-ai bot deleted the sourcery/pull-3 branch January 12, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant