Retro achievements implementation #2529
Conversation
…look on par, + deletion of unused include. I think that is last thing that was missing from that fork and probably last revision.
|
Its still very early, I need to clean up more code for it to be at least torelable for pull request |
src/CMakeLists.txt
Outdated
| if(DEFINED ENV{MSYSTEM_PREFIX}) | ||
| set(CURL_LDIR "$ENV{MSYSTEM_PREFIX}/lib") | ||
| else() | ||
| set(CURL_LDIR "C:/msys64/ucrt64/lib") |
There was a problem hiding this comment.
Why is this path hardcoded?
It appears that this code won't find cURL and SSL libraries on non-Windows (non-MSYS2, even) platforms as it stands.
There was a problem hiding this comment.
Now it should be resolved, or at least better, I had my fair share of problems with implementing curl and making it work in a static build. I still have it "hardcoded" but only for Windows, because every time I try to link it automatically, the exe still says it requires some dlls. No idea if Linux/Mac will work, but now there is a chance at least.
| SPI.Reset(); | ||
| RTC.Reset(); | ||
| Wifi.Reset(); | ||
| memset(MainRAM, 0, MainRAMMask + 1); |
There was a problem hiding this comment.
Why is the memset() done here? It is already done in SetupDirectBoot, which makes sense as that path skips BIOS/firmware, and I'm not sure if the console RAM is actually zero on cold boot on real hardware. Did you verify this or do you have a source for this?
There was a problem hiding this comment.
I did implement this because I got a random achievement on starting a new game without fully restarting the emulator. I didn't really verify it, but it requires further testing if needed.
|
I understand że shit ale po poprawkach by przeszło, XD. Implementacja totalnie podstawowa buildowałem aż do sukcesu, dopiero teraz usuwam nieużywany kod i błędy. |
|
Leave it alone for now... As much as I respect your half of the effort, I'm not sure @Arisotura will be keen on merging "vibe-coded" contributions regardless. |
|
This is just for testing and not intended for merging. It's a draft to track changes from melonDS main and help me refine the code. And I don't think it will ever be as refined as normal integrations, but it is something. |
|
Update 1. Changed it to support instances. Now you can play with your friends and earn achievements separately. Tidied and deleted files that were not used so it should be better to build and run. Still not sure if Linux and Mac are supported, but if I had some feedback i am sure it would be fixable. Also added your pfp on logging into RA, and changed the menu location from inside emusettings to its own RA settings under Config dropdown. |
|
Also, I am now opening it for a review because the core code is now at least pretty clean. I am sure some useless code could have snuck in, but now i am positive it is better than before. Here are instructions for building your own RA build
|
2 participants
Bringing RetroAchievements (RA) support to melonDS.
I saw that the community really wanted RA support, so I decided to take on the challenge. This is a rough, beta implementation that I’ve tested extensively over the last week. I am a huge fan of RetroAchievements and very proud of this project.
Important: This is currently unofficial, so Hardcore mode does not yet provide official Hardcore points.
✅ Current Features
Full backend integration.
Core frontend implementation.
Basic connectivity and achievement unlocking.
Achievements and their info is shown when getting them.
Basic Login in EmuSettings under new tab.
🛠️ Known Issues & Planned Features
Leaderboards: Not yet implemented.
Overlay: Missing in-game achievement list.
Progress Indicators: Achievement progress is not currently tracked visually, there is only notification on getting achievement.
Hardcore Approval: Still fixing stuff, so when it will be more than a beta then it could be possible.
Memory Access: VRAM and ARM9 IO memory reading is missing (may affect specific achievements, but i wouldn't worry about that).
Offline Caching: Session recovery works, but the emulator does not cache achievement data to local files yet.
Player Profile: Visible points and profile integration (optional).
Full Disclosure: This feature also was developed using "vibecoding" (this time mainly ChatGpt and Gemini). I really put my heart into that implementation, and I hope people will actually think of it as nice thing, so I don't consider my time as wasted.