-
-
Notifications
You must be signed in to change notification settings - Fork 675
Retro Achievements implementation #2529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PanMenel
wants to merge
43
commits into
melonDS-emu:master
Choose a base branch
from
PanMenel:Retro-Achievements-Implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
6f39652
Update InputConfigDialog.h
PanMenel fc2b34d
This should work I guess
PanMenel fcf6a8f
Gówno fix usuwający feature
PanMenel 5dcc694
fix gówno fixa i guess
PanMenel 29a92d3
Epic update, i hope it works XD
PanMenel 1dc324a
fix better buildu
PanMenel e4a2672
fix fixa XD
PanMenel bfb988b
i am so fucking stupid fix
PanMenel 814ad81
Update README.md
PanMenel d03f875
Update README.md
PanMenel baf8bfa
Update README.md
PanMenel 1690b03
Cosmetic changes to ReadMe
PanMenel e37fa68
my stupid ass added button traping users
PanMenel 14805c1
fix because unused code
PanMenel 1a76845
even stupider case for a fix
PanMenel 0c04ac3
more unused code
PanMenel e389058
revert on readme
PanMenel 8bdda09
Reworked EmuInstanceInput.cpp to not touch existing code and made it …
PanMenel f93c230
if function shift to look more clean
PanMenel 3b75b1e
Full Rewrite to fit more into melonds code
PanMenel 3e19c52
Update Config.h
PanMenel c55230e
Update Config.cpp
PanMenel 71ddddc
Update EmuSettingsDialog.cpp
PanMenel ec2c4e9
First batch of changes. could be wrong
PanMenel ee8b670
added new files and batch2
PanMenel a81d479
RA files
PanMenel 1dbec57
RA frontend files
PanMenel e9a0211
Rcheevos files
PanMenel b5dd626
Rcheevos v2
PanMenel 921c74e
rcheevos v3
PanMenel 9469e46
rcheevos v4
PanMenel 7281d90
somehow - snuck in
PanMenel 759e403
Merge branch 'melonDS-emu:master' into Retro-Achievements-Implementation
PanMenel 4112671
core fixes and changes
PanMenel 1789c3c
changes to frontend nr.1
PanMenel 8c7c3c9
Some cleanup
PanMenel 4e60f9e
forgor .ui
PanMenel c025f97
Toast Manager fixes to fix compiling
PanMenel 738a8ca
now toast should be good i guess
PanMenel 0ec40be
More cleaning up
PanMenel 785e00b
EVEN MORE CLEANING UP
PanMenel 15be17b
Merge branch 'melonDS-emu:master' into Retro-Achievements-Implementation
PanMenel 2d951aa
mainly revert changes from my other fork
PanMenel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the
memset()done here? It is already done inSetupDirectBoot, which makes sense as that path skips BIOS/firmware, and I'm not sure if the console RAM is actually zero on cold boot on real hardware. Did you verify this or do you have a source for this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did implement this because I got a random achievement on starting a new game without fully restarting the emulator. I didn't really verify it, but it requires further testing if needed.