feat: WSL2 as a Firmware Development Environment#516
Merged
gminn merged 9 commits intomemfault:masterfrom Oct 7, 2024
Merged
Conversation
This was referenced Sep 19, 2024
gminn
requested changes
Sep 26, 2024
Member
gminn
left a comment
gminn
left a comment
There was a problem hiding this comment.
@JPHutchins This is an awesome article! I have a handful of questions and requests before we move to the next step.
The patches that were made were for better terminal compatibility, they wouldn't have impacted the test run.
Contributor
Author
|
@gminn Thanks for the detailed review! I closed a few the conversations where the change was pretty straightforward and left the others open. |
gminn
approved these changes
Oct 4, 2024
Member
gminn
left a comment
gminn
left a comment
There was a problem hiding this comment.
Thank you for the great draft @JPHutchins ! We'll work on a final grammar pass, followed by a publish PR.
Member
Merge activity
|
gminn
pushed a commit
that referenced
this pull request
Dec 2, 2024
Original PR here: #515 This PR assumes that #516 has been merged. This part of the previous article should be updated to link to this article instead of GitHub: https://github.com/intercreate/interrupt/blob/795a1678485adfd1a07d82e0fa73282ecea0144f/_drafts/wsl2-as-a-firmware-development-environment.md?plain=1#L476-L480 JP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR here: #515
Mermaid support is added, which is optionally enabled with
mermaid: trueat the top of an article.JP