Skip to content

feat: WSL2 for Firmware Development#517

Merged
gminn merged 1 commit intomemfault:masterfrom
intercreate:draft/wsl2-for-firmware-development-tutorial
Dec 2, 2024
Merged

feat: WSL2 for Firmware Development#517
gminn merged 1 commit intomemfault:masterfrom
intercreate:draft/wsl2-for-firmware-development-tutorial

Conversation

@JPHutchins
Copy link
Contributor

Original PR here: #515

This PR assumes that #516 has been merged.

This part of the previous article should be updated to link to this article instead of GitHub: https://github.com/intercreate/interrupt/blob/795a1678485adfd1a07d82e0fa73282ecea0144f/_drafts/wsl2-as-a-firmware-development-environment.md?plain=1#L476-L480

JP

@JPHutchins JPHutchins requested a review from a team as a code owner September 19, 2024 22:29
Copy link
Member

@gminn gminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JPHutchins Thank you for this second article! I like how practical and straighforward it is. I have a few comments below but I have one main one: I understand this comes from your own walk-through tutorial, but I'm curious if you'd be open to writing it more in the style of a blog post, where you narrate each section explaining the goal of each step, and maybe some experiences you had landing on this particular approach. Lmk what you think!

@JPHutchins JPHutchins requested a review from gminn December 1, 2024 22:41
Copy link
Member

@gminn gminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @JPHutchins ! Thank you for taking the time to adjust the prose and flesh out a few sections. I have one fix to request before we can merge the draft

@JPHutchins JPHutchins force-pushed the draft/wsl2-for-firmware-development-tutorial branch from 5deba55 to 87413fc Compare December 2, 2024 20:12
@JPHutchins JPHutchins requested a review from gminn December 2, 2024 20:13
@JPHutchins
Copy link
Contributor Author

This looks great @JPHutchins ! Thank you for taking the time to adjust the prose and flesh out a few sections. I have one fix to request before we can merge the draft

Great - rebased and squashed ✅

@gminn gminn merged commit 1a81288 into memfault:master Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants