Fix scrolling jump between pages#23
Closed
sergiogarciadev wants to merge 1 commit into
Closed
Conversation
Member
|
Wow, thanks for working on this. I tested it and it indeed solves this problem, but it somehow breaks long searches. To reproduce:
It goes to F33A8, but the string is actually at F23A8. It also breaks
It goes to 0x1000, but the next other byte is at 0x4000. Also Do you think you can fix it? Thanks in advance. |
Contributor
Author
|
This was supersede by #24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #5.
To effectively fix this, we need to have in memory the previous and next caches (4096 bytes), which means that instead of loading just 4096 bytes we must load 3x that, this has no significant impact on performance due to still being very small.
It may have a small performance impact on search, due to repeated reading the same blocks, but due to OS cache this should be minimal and it avoid a major refactor on project.