Refactored file access to use memory mapped file#24
Merged
Conversation
sergiogarciadev
force-pushed
the
reader_refactor
branch
from
887796d to
39045c8
Compare
Member
|
This is quite nice, @sergiogarciadev. I just tested and couldn't see any bugs related to your PR. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big change, take extra care when testing.
This PR refactor file access to use Memory Mapped IO, which let us handle file access like if the entire file was on memory. Actual read from disk occurs each time we access a page for the first time, make it very easy to the programmer as it doesn't need to calculation to check if a page is cached or problems like rendering page between cache boundaries, enabling smoother transition between pages.
As cache is now handled by the OS, pages can be dynamic calculated to use all the available terminal size.
This PR should fix #4 and #5, it will also makes fixing #9 easier.
It also should fixes #10 , but I think there is room for improvement.