Merged
Conversation
Contributor
drcrallen
commented
Sep 14, 2016
drcrallen
commented
- Also adds test
* Also adds test
Contributor
Author
Contributor
|
Reflection approach is used, when somebody needs graceful fail when non-HotSpot JVM is used. I. e. somebody trying to use java-util from within Websphere will be in thouble, because it runs on IBM's J9. If we explicitly support only Hotspot JVM I think this is a good change. |
Contributor
|
Ok, i see that exceptions were thrown in static blocks before, so It was not compatible with other JVMs anyway. |
| clean((DirectBuffer) buffer); | ||
| } | ||
| } | ||
| catch (Exception e) { |
Contributor
There was a problem hiding this comment.
Is try-catch needed here?
Contributor
Author
There was a problem hiding this comment.
Don't think so. Fixed, er... removed
leventov
approved these changes
Sep 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.