chore: add deprecation message to 'pipe-naming' rule#593
Merged
mgechev merged 1 commit intomgechev:masterfrom May 2, 2018
rafaelss95:chore-pipe-naming-rule
Merged
chore: add deprecation message to 'pipe-naming' rule#593mgechev merged 1 commit intomgechev:masterfrom rafaelss95:chore-pipe-naming-rule
mgechev merged 1 commit intomgechev:masterfrom
rafaelss95:chore-pipe-naming-rule
Conversation
Collaborator
Author
|
@mgechev @wKoza while I do understand why it's deprecated, I can still see useful things in it such as enforcing prefixes like we do for Can't we just deprecate the actual configuration? A new configuration could be like this: |
mgechev
approved these changes
May 2, 2018
Owner
|
@rafaelss95 I like the regex config: It'll make more sense to rename the rule. If we have a rule with the same name but different semantics we'll create a lot of confusion. |
Collaborator
Author
|
Does it makes sense to create another rule now? Or better wait for complete removal of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once someone try to use this deprecated rule, it'll show a warning like:
Not sure if it's the best message, but I've picked it in #519 (comment).