feat(rule): add pipe-prefix rule#693
Merged
mgechev merged 4 commits intomgechev:masterfrom Aug 2, 2018
Merged
Conversation
Contributor
Author
|
@mgechev thanks for codelyzer and please let me know if anything should be updated and if this PR makes any sense at all. I'm not sure about messages correctness. English language is not my strongest side. |
Contributor
Author
|
I've just discovered some test cases cause this error: Fixed with this commit f388737 |
mgechev
approved these changes
Aug 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #519 and #593 discussions adding pipe-prefix rule and pointing users to it in pipe-naming deprecation.