Skip to content

bug: review-responder fails to resolve threads after pushing code #95

@microsasa

Description

@microsasa

Bug

The Review Responder pushes a fix commit, replies to the review comment, then tries to resolve the thread — but the resolve fails because the push invalidated the thread ID.

Error

##[error]Failed to resolve review thread: Request failed due to following response errors:
 - Could not resolve to a node with the global id of 'PRRT_kwDONu0E4c6EdG-e'.

Root Cause

The agent emits safe-outputs in the wrong order:

  1. add_labels
  2. push_to_pull_request_branch ✅ — pushes fix commit, invalidates thread
  3. reply_to_pull_request_review_comment ✅ — replies to thread
  4. resolve_pull_request_review_thread ❌ — thread ID is stale after push

Fix

Update review-responder instructions to specify the correct ordering: reply → resolve → push. Resolve threads while the code they reference is still current, then push the fix. The agent controls the order it emits safe-outputs — we just need to tell it explicitly.

Impact

With required_conversation_resolution: true, unresolved threads block auto-merge. The Review Responder addresses the comment and pushes a fix, but the thread stays unresolved — PR is stuck.

Observed On

PR #91 — Review Responder run 23117899192. Thread addressed, fix pushed, reply posted, but resolve failed. Had to manually resolve the thread.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions